Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: safe debug service url #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: safe debug service url #5

wants to merge 1 commit into from

Conversation

NNA
Copy link

@NNA NNA commented Oct 15, 2024

service url may contain sensitive information like passwords that should not leak in tracing / logs.

Oct 15 09:11:44 myserver watchdog.sh[147855]: {"timestamp":"2024-10-15T09:11:44.028890Z","level":"DEBUG","message":"create channel","id":"1","target":"lapin::channels","span":{"src":"\"amqp://mylogin:[email protected]/product\"","url":"amqp://mylogin:[email protected]/product","name":"connect"},

This PR introduces a new Struct CelerySource(String) replacing regular String for service URL. When displaying or calling debug on CelerySource, method safe_source is called and strips away the password if there is one.

With this change, this is the output :

Oct 15 09:11:44 myserver watchdog.sh[147855]: {"timestamp":"2024-10-15T09:11:44.028890Z","level":"DEBUG","message":"create channel","id":"1","target":"lapin::channels","span":{"src":"\"amqp://mylogin:********@rabbitmq.myserver.com/product\"","url":"amqp://mylogin:********@rabbitmq.myserver.com/product","name":"connect"},

feat: safe debug service url
232f8a0 
service url may contain sensitive information like password that should not leak in tracing / logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NNA